marcoallegretti/shift-shell
1
0
Fork 0
mirror of https://invent.kde.org/marcoa/shift-shell.git synced 2026-04-29 15:03:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

navigationpanel: Remove feature that moves it to the right when the screen height is small

Browse source 
This feature continuously causes issues, and I don't really have time to keep looking at it again and again.

https://invent.kde.org/plasma/plasma-mobile/-/issues/321
This commit is contained in:
Devin Lin 2024-03-26 20:53:56 -04:00
parent 4364af86bc
commit e7877a6d7a
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
components/mobileshell/qml/components/Constants.qml
View file

@ -16,6 +16,10 @@ QtObject {
readonly property real navigationPanelThickness: ShellSettings.Settings.navigationPanelEnabled ? Kirigami.Units.gridUnit * 2 : 0
function navigationPanelOnSide(screenWidth: real, screenHeight: real): bool {
return screenWidth > screenHeight && screenHeight < 500;
// TODO: we have this disabled for now, we might consider just removing this feature entirely due to it causing several issues:
// (the feature being the navigation panel being moved to the right when the screen height is small)
// => the keyboard dimensions are incorrect
// => shell seems to crash randomly (attempted hotfixes with just delay timers, but not great and also doesn't work now)
return false; // screenWidth > screenHeight && screenHeight < 500;
}
}