From e7877a6d7ab64543c2233de432680818e4ac6e7f Mon Sep 17 00:00:00 2001 From: Devin Lin Date: Tue, 26 Mar 2024 20:53:56 -0400 Subject: [PATCH] navigationpanel: Remove feature that moves it to the right when the screen height is small This feature continuously causes issues, and I don't really have time to keep looking at it again and again. https://invent.kde.org/plasma/plasma-mobile/-/issues/321 --- components/mobileshell/qml/components/Constants.qml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/components/mobileshell/qml/components/Constants.qml b/components/mobileshell/qml/components/Constants.qml index 89f2d8e9..dcb75cfe 100644 --- a/components/mobileshell/qml/components/Constants.qml +++ b/components/mobileshell/qml/components/Constants.qml @@ -16,6 +16,10 @@ QtObject { readonly property real navigationPanelThickness: ShellSettings.Settings.navigationPanelEnabled ? Kirigami.Units.gridUnit * 2 : 0 function navigationPanelOnSide(screenWidth: real, screenHeight: real): bool { - return screenWidth > screenHeight && screenHeight < 500; + // TODO: we have this disabled for now, we might consider just removing this feature entirely due to it causing several issues: + // (the feature being the navigation panel being moved to the right when the screen height is small) + // => the keyboard dimensions are incorrect + // => shell seems to crash randomly (attempted hotfixes with just delay timers, but not great and also doesn't work now) + return false; // screenWidth > screenHeight && screenHeight < 500; } }