marcoallegretti/shift-shell
1
0
Fork 0
mirror of https://invent.kde.org/marcoa/shift-shell.git synced 2026-04-26 06:13:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Ensure i18n is used with double quotes and add CI check

Browse source 
Apparently i18n doesn't support string literals with single quotes as
parameters. Fix occurrences of this and add a CI check to ensure this
won't happen in the future.
This commit is contained in:
Devin Lin 2025-08-10 14:52:25 -04:00
parent 749c0de5d5
commit c76e19037c
11 changed files with 28 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.gitlab-ci.yml
View file

@ -10,6 +10,7 @@ include:
- /gitlab-templates/alpine-qt6.yml
- /gitlab-templates/xml-lint.yml
- /gitlab-templates/yaml-lint.yml
- /gitlab-templates/qml-lint.yml
posix-script-compliance:
image:

2
containments/homescreens/folio/qml/HomeScreenPage.qml
View file

@ -374,7 +374,7 @@ Item {
PC3.ToolTip {
visible: widgetDelegate.editMode && pressed
text: i18n('Release to configure, drag to move')
text: i18n("Release to configure, drag to move")
}
WidgetDelegateConfig {

4
containments/homescreens/folio/qml/delegate/WidgetDelegate.qml
View file

@ -116,7 +116,7 @@ Folio.WidgetContainer {
visible: root.widget && !root.widget.visualApplet
color: 'white'
wrapMode: Text.Wrap
text: i18n('This widget was not found.')
text: i18n("This widget was not found.")
horizontalAlignment: Text.AlignHCenter
anchors.left: parent.left
@ -134,7 +134,7 @@ Folio.WidgetContainer {
PC3.Button {
id: configurationRequiredButton
anchors.centerIn: parent
text: i18n('Configure…')
text: i18n("Configure…")
icon.name: 'configure'
visible: root.widget && root.widget.applet && root.widget.applet.configurationRequired
onClicked: root.widget.applet.internalAction('configure').trigger();

8
containments/homescreens/folio/qml/delegate/WidgetDelegateConfig.qml
View file

@ -192,7 +192,7 @@ Item {
PC3.Button {
id: button
icon.name: 'settings-configure'
text: i18n('Options')
text: i18n("Options")
display: (resizeFrame.handleContainer.width > Kirigami.Units.gridUnit * 7) ? PC3.Button.TextBesideIcon : PC3.Button.IconOnly
readonly property var handleContainer: resizeFrame.handleContainer
@ -206,7 +206,7 @@ Item {
id: contextMenuDialog
preferredWidth: Kirigami.Units.gridUnit * 20
padding: 0
title: i18n('Widget Options')
title: i18n("Widget Options")
// workaround: remove background so that it doesn't remain if the widget is deleted (and this is de-initialized without closing)
QQC2.Overlay.modal: null
@ -246,14 +246,14 @@ Item {
Kirigami.Action {
id: removeDelegateAction
icon.name: 'edit-delete-remove'
text: i18n('Remove widget')
text: i18n("Remove widget")
onTriggered: root.removeRequested()
}
Kirigami.Action {
id: configureAppletAction
icon.name: 'settings-configure'
text: i18n('Configure widget')
text: i18n("Configure widget")
onTriggered: root.widget.applet.internalAction('configure').trigger();
}
}

4
containments/homescreens/folio/qml/private/ConfirmDeleteFolderDialogLoader.qml
View file

@ -31,8 +31,8 @@ Loader {
sourceComponent: Kirigami.PromptDialog {
id: menu
title: i18n('Confirm Folder Deletion')
subtitle: i18n('Are you sure you want to delete this folder?')
title: i18n("Confirm Folder Deletion")
subtitle: i18n("Are you sure you want to delete this folder?")
standardButtons: Kirigami.Dialog.Yes | Kirigami.Dialog.Cancel
onAccepted: root.accepted()

6
containments/homescreens/folio/qml/settings/SettingsComponent.qml
View file

@ -79,7 +79,7 @@ Item {
QQC2.Label {
Layout.alignment: Qt.AlignHCenter | Qt.AlignTop
text: i18n('Wallpapers')
text: i18n("Wallpapers")
font.bold: true
}
}
@ -107,7 +107,7 @@ Item {
QQC2.Label {
Layout.alignment: Qt.AlignHCenter | Qt.AlignTop
text: i18n('Settings')
text: i18n("Settings")
font.bold: true
}
}
@ -136,7 +136,7 @@ Item {
QQC2.Label {
Layout.alignment: Qt.AlignHCenter | Qt.AlignTop
text: i18n('Widgets')
text: i18n("Widgets")
font.bold: true
}
}

8
containments/homescreens/folio/qml/settings/SettingsWindow.qml
View file

@ -102,7 +102,7 @@ Window {
anchors.centerIn: parent
implicitHeight: folio.HomeScreenState.pageCellHeight
implicitWidth: folio.HomeScreenState.pageCellWidth
name: i18n('Application')
name: i18n("Application")
contentItem: DelegateAppIcon {
height: root.folio.FolioSettings.delegateIconSize
@ -254,7 +254,7 @@ Window {
FormCard.FormCard {
FormCard.FormSwitchDelegate {
text: i18n('Show background')
text: i18n("Show background")
checked: folio.FolioSettings.showFavouritesBarBackground
onCheckedChanged: {
if (checked !== folio.FolioSettings.showFavouritesBarBackground) {
@ -307,7 +307,7 @@ Window {
FormCard.FormButtonDelegate {
id: exportSettings
text: i18n('Export layout')
text: i18n("Export layout")
icon.name: 'document-export'
onClicked: exportFileDialog.open()
}
@ -316,7 +316,7 @@ Window {
FormCard.FormButtonDelegate {
id: importSettings
text: i18n('Import layout')
text: i18n("Import layout")
icon.name: 'document-import'
onClicked: importFileDialog.open()
}

4
containments/homescreens/halcyon/qml/settings/SettingsScreen.qml
View file

@ -68,7 +68,7 @@ Item {
QQC2.Label {
Layout.alignment: Qt.AlignHCenter | Qt.AlignTop
text: i18n('Wallpapers')
text: i18n("Wallpapers")
font.bold: true
}
}
@ -96,7 +96,7 @@ Item {
QQC2.Label {
Layout.alignment: Qt.AlignHCenter | Qt.AlignTop
text: i18n('Settings')
text: i18n("Settings")
font.bold: true
}
}

8
initialstart/modules/wifi/package/contents/ui/ConnectionItemDelegate.qml
View file

@ -75,21 +75,21 @@ FormCard.AbstractFormDelegate {
}
Controls.ToolButton {
icon.name: "network-connect"
text: i18n('Connect')
text: i18n("Connect")
visible: ConnectionState != PlasmaNM.Enums.Activated && root.editMode
display: Controls.ToolButton.IconOnly
onClicked: changeState()
}
Controls.ToolButton {
icon.name: "network-disconnect"
text: i18n('Disconnect')
text: i18n("Disconnect")
visible: ConnectionState == PlasmaNM.Enums.Activated && root.editMode
display: Controls.ToolButton.IconOnly
onClicked: handler.deactivateConnection(ConnectionPath, DevicePath)
}
Controls.ToolButton {
icon.name: "configure"
text: i18n('Configure')
text: i18n("Configure")
visible: (Uuid != "") && root.editMode
display: Controls.ToolButton.IconOnly
onClicked: {
@ -98,7 +98,7 @@ FormCard.AbstractFormDelegate {
}
Controls.ToolButton {
icon.name: "entry-delete"
text: i18n('Delete')
text: i18n("Delete")
visible: (Uuid != "") && root.editMode
display: Controls.ToolButton.IconOnly
onClicked: handler.removeConnection(ConnectionPath)

2
kcms/waydroidintegration/ui/WaydroidConfigurationForm.qml
View file

@ -25,7 +25,7 @@ ColumnLayout {
description: AIP.WaydroidState.ipAddress
trailing: PC3.Button {
visible: AIP.WaydroidState.ipAddress !== ""
text: i18n('Copy')
text: i18n("Copy")
icon.name: 'edit-copy-symbolic'
onClicked: AIP.WaydroidState.copyToClipboard(AIP.WaydroidState.ipAddress)
}

2
kwin/mobiletaskswitcher/package/contents/ui/main.qml
View file

@ -20,7 +20,7 @@ SceneEffect {
ShortcutHandler {
name: 'Mobile Task Switcher'
text: i18n('Toggle Mobile Task Switcher')
text: i18n("Toggle Mobile Task Switcher")
sequence: 'Meta+C'
onActivated: taskSwitcherState.toggle()