marcoallegretti/shift-shell
1
0
Fork 0
mirror of https://invent.kde.org/marcoa/shift-shell.git synced 2026-04-26 06:13:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

mobileshellstate: Fetch initial state properly, and check property

Browse source 
Ensure that all of the variables have their initial state fetched at the
start with the shell DBus client. Also ensure that they only emit
property changes when they actually happen.
This commit is contained in:
Devin Lin 2025-08-08 18:08:46 -04:00
parent 8fe62e05a4
commit 749c0de5d5
1 changed files with 41 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

53
components/mobileshellstate/shelldbusclient.cpp
View file

@ -52,6 +52,11 @@ void ShellDBusClient::connectSignals()
connect(m_interface, &OrgKdePlasmashellInterface::showVolumeOSDRequested, this, &ShellDBusClient::showVolumeOSDRequested);
connect(m_interface, &OrgKdePlasmashellInterface::openLockScreenKeypadRequested, this, &ShellDBusClient::openLockScreenKeypadRequested);
// Initial state fetch
updatePanelState();
updateIsActionDrawerOpen();
updateIsVolumeOSDOpen();
updateIsNotificationPopupDrawerOpen();
updateDoNotDisturb();
updateIsTaskSwitcherVisible();
}
@ -164,8 +169,12 @@ void ShellDBusClient::updatePanelState()
QObject::connect(watcher, &QDBusPendingCallWatcher::finished, this, [this](auto watcher) {
QDBusPendingReply<QString> reply = *watcher;
m_panelState = reply.argumentAt<0>();
Q_EMIT panelStateChanged();
QString panelState = reply.argumentAt<0>();
if (panelState != m_panelState) {
m_panelState = panelState;
Q_EMIT panelStateChanged();
}
});
}
@ -176,8 +185,12 @@ void ShellDBusClient::updateDoNotDisturb()
QObject::connect(watcher, &QDBusPendingCallWatcher::finished, this, [this](auto watcher) {
QDBusPendingReply<bool> reply = *watcher;
m_doNotDisturb = reply.argumentAt<0>();
Q_EMIT doNotDisturbChanged();
bool doNotDisturb = reply.argumentAt<0>();
if (doNotDisturb != m_doNotDisturb) {
m_doNotDisturb = doNotDisturb;
Q_EMIT doNotDisturbChanged();
}
});
}
@ -188,8 +201,12 @@ void ShellDBusClient::updateIsActionDrawerOpen()
QObject::connect(watcher, &QDBusPendingCallWatcher::finished, this, [this](auto watcher) {
QDBusPendingReply<bool> reply = *watcher;
m_isActionDrawerOpen = reply.argumentAt<0>();
Q_EMIT isActionDrawerOpenChanged();
bool isActionDrawerOpen = reply.argumentAt<0>();
if (isActionDrawerOpen != m_isActionDrawerOpen) {
m_isActionDrawerOpen = isActionDrawerOpen;
Q_EMIT isActionDrawerOpenChanged();
}
});
}
@ -200,8 +217,12 @@ void ShellDBusClient::updateIsVolumeOSDOpen()
QObject::connect(watcher, &QDBusPendingCallWatcher::finished, this, [this](auto watcher) {
QDBusPendingReply<bool> reply = *watcher;
m_isVolumeOSDOpen = reply.argumentAt<0>();
Q_EMIT isVolumeOSDOpenChanged();
bool isVolumeOSDOpen = reply.argumentAt<0>();
if (isVolumeOSDOpen != m_isVolumeOSDOpen) {
m_isVolumeOSDOpen = isVolumeOSDOpen;
Q_EMIT isVolumeOSDOpenChanged();
}
});
}
@ -212,8 +233,12 @@ void ShellDBusClient::updateIsNotificationPopupDrawerOpen()
QObject::connect(watcher, &QDBusPendingCallWatcher::finished, this, [this](auto watcher) {
QDBusPendingReply<bool> reply = *watcher;
m_isNotificationPopupDrawerOpen = reply.argumentAt<0>();
Q_EMIT isNotificationPopupDrawerOpenChanged();
bool isNotificationPopupDrawerOpen = reply.argumentAt<0>();
if (isNotificationPopupDrawerOpen != m_isNotificationPopupDrawerOpen) {
m_isNotificationPopupDrawerOpen = isNotificationPopupDrawerOpen;
Q_EMIT isNotificationPopupDrawerOpenChanged();
}
});
}
@ -224,7 +249,11 @@ void ShellDBusClient::updateIsTaskSwitcherVisible()
QObject::connect(watcher, &QDBusPendingCallWatcher::finished, this, [this](auto watcher) {
QDBusPendingReply<bool> reply = *watcher;
m_isTaskSwitcherVisible = reply.argumentAt<0>();
Q_EMIT isTaskSwitcherVisibleChanged();
bool isTaskSwitcherVisible = reply.argumentAt<0>();
if (isTaskSwitcherVisible != m_isTaskSwitcherVisible) {
m_isTaskSwitcherVisible = isTaskSwitcherVisible;
Q_EMIT isTaskSwitcherVisibleChanged();
}
});
}