marcoallegretti/shift-shell
1
0
Fork 0
mirror of https://invent.kde.org/marcoa/shift-shell.git synced 2026-04-29 07:03:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix NotificationItem to not override a final property

Browse source 
makes it work with the newest version of Kirigami https://invent.kde.org/frameworks/kirigami/-/merge_requests/1293
Inspired by https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3409

On my machine this makes a fully fresh built plasma-mobile & all its dependencies work again
This commit is contained in:
Luis Büchi 2023-10-20 01:14:26 +00:00 committed by Devin Lin
parent e7524d4977
commit 19de084968
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
components/mobileshell/qml/widgets/notifications/NotificationItem.qml
View file

@ -125,17 +125,17 @@ BaseNotificationItem {
Layout.topMargin: Kirigami.Units.smallSpacing Layout.topMargin: Kirigami.Units.smallSpacing
Layout.bottomMargin: Kirigami.Units.smallSpacing Layout.bottomMargin: Kirigami.Units.smallSpacing
visible: iconItem.active visible: iconItem.shouldBeShown
Kirigami.Icon { Kirigami.Icon {
id: iconItem id: iconItem
// don't show two identical icons // don't show two identical icons
readonly property bool active: valid && source != notificationItem.applicationIconSource readonly property bool shouldBeShown: valid && source != notificationItem.applicationIconSource
anchors.fill: parent anchors.fill: parent
smooth: true smooth: true
// don't show a generic "info" icon since this is a notification already // don't show a generic "info" icon since this is a notification already
source: notificationItem.icon !== "dialog-information" ? notificationItem.icon : "" source: notificationItem.icon !== "dialog-information" ? notificationItem.icon : ""
visible: active visible: shouldBeShown
} }
} }
} }