From 19de0849683387d57eac84a13ea52d3cb32d3da3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luis=20B=C3=BCchi?= Date: Fri, 20 Oct 2023 01:14:26 +0000 Subject: [PATCH] fix NotificationItem to not override a final property makes it work with the newest version of Kirigami https://invent.kde.org/frameworks/kirigami/-/merge_requests/1293 Inspired by https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3409 On my machine this makes a fully fresh built plasma-mobile & all its dependencies work again --- .../qml/widgets/notifications/NotificationItem.qml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/components/mobileshell/qml/widgets/notifications/NotificationItem.qml b/components/mobileshell/qml/widgets/notifications/NotificationItem.qml index 0f5d58d9..9510af72 100644 --- a/components/mobileshell/qml/widgets/notifications/NotificationItem.qml +++ b/components/mobileshell/qml/widgets/notifications/NotificationItem.qml @@ -125,17 +125,17 @@ BaseNotificationItem { Layout.topMargin: Kirigami.Units.smallSpacing Layout.bottomMargin: Kirigami.Units.smallSpacing - visible: iconItem.active + visible: iconItem.shouldBeShown Kirigami.Icon { id: iconItem // don't show two identical icons - readonly property bool active: valid && source != notificationItem.applicationIconSource + readonly property bool shouldBeShown: valid && source != notificationItem.applicationIconSource anchors.fill: parent smooth: true // don't show a generic "info" icon since this is a notification already source: notificationItem.icon !== "dialog-information" ? notificationItem.icon : "" - visible: active + visible: shouldBeShown } } }