marcoallegretti/shift-shell
1
0
Fork 0
mirror of https://invent.kde.org/marcoa/shift-shell.git synced 2026-08-01 01:07:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kcms/mobileshell: Remove gesture only navigation option for now

Browse source 
The KWin gesture currently does not work at all, so turning off the navigation panel makes it so the user cannot navigate.

See https://invent.kde.org/plasma/plasma-mobile/-/issues/300
This commit is contained in:
Devin Lin 2024-01-21 22:54:32 -05:00
parent d375914a8c
commit 037f24833c
2 changed files with 15 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
components/shellsettingsplugin/mobileshellsettings.cpp
View file

@ -91,7 +91,8 @@ void MobileShellSettings::setNavigationPanelEnabled(bool navigationPanelEnabled)
group.writeEntry("navigationPanelEnabled", navigationPanelEnabled, KConfigGroup::Notify); group.writeEntry("navigationPanelEnabled", navigationPanelEnabled, KConfigGroup::Notify);
m_config->sync(); m_config->sync();
updateNavigationBarsInPlasma(navigationPanelEnabled); // TODO: Gesture only mode setting is disabled until we get the kwin effect gesture working: https://invent.kde.org/plasma/plasma-mobile/-/issues/300
// updateNavigationBarsInPlasma(navigationPanelEnabled);
} }
bool MobileShellSettings::alwaysShowKeyboardToggleOnNavigationPanel() const bool MobileShellSettings::alwaysShowKeyboardToggleOnNavigationPanel() const

25
kcms/mobileshell/ui/main.qml
View file

@ -54,19 +54,20 @@ KCM.SimpleKCM {
} }
FormCard.FormCard { FormCard.FormCard {
FormCard.FormSwitchDelegate { // TODO: Gesture only mode setting is disabled until we get the kwin effect gesture working: https://invent.kde.org/plasma/plasma-mobile/-/issues/300
id: gestureDelegate // FormCard.FormSwitchDelegate {
text: i18n("Gesture-only Mode") // id: gestureDelegate
description: i18n("Whether to hide the navigation panel.") // text: i18n("Gesture-only Mode")
checked: !ShellSettings.Settings.navigationPanelEnabled // description: i18n("Whether to hide the navigation panel.")
onCheckedChanged: { // checked: !ShellSettings.Settings.navigationPanelEnabled
if (checked != !ShellSettings.Settings.navigationPanelEnabled) { // onCheckedChanged: {
ShellSettings.Settings.navigationPanelEnabled = !checked; // if (checked != !ShellSettings.Settings.navigationPanelEnabled) {
} // ShellSettings.Settings.navigationPanelEnabled = !checked;
} // }
} // }
// }
FormCard.FormDelegateSeparator { visible: keyboardToggleDelegate.visible; above: gestureDelegate; below: keyboardToggleDelegate } // FormCard.FormDelegateSeparator { visible: keyboardToggleDelegate.visible; above: gestureDelegate; below: keyboardToggleDelegate }
FormCard.FormSwitchDelegate { FormCard.FormSwitchDelegate {
id: keyboardToggleDelegate id: keyboardToggleDelegate