From 037f24833c2cd07b3eb62e1aa0bbc3ebeef73527 Mon Sep 17 00:00:00 2001 From: Devin Lin Date: Sun, 21 Jan 2024 22:54:32 -0500 Subject: [PATCH] kcms/mobileshell: Remove gesture only navigation option for now The KWin gesture currently does not work at all, so turning off the navigation panel makes it so the user cannot navigate. See https://invent.kde.org/plasma/plasma-mobile/-/issues/300 --- .../mobileshellsettings.cpp | 3 ++- kcms/mobileshell/ui/main.qml | 25 ++++++++++--------- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/components/shellsettingsplugin/mobileshellsettings.cpp b/components/shellsettingsplugin/mobileshellsettings.cpp index b47e0a56..6d2893d1 100644 --- a/components/shellsettingsplugin/mobileshellsettings.cpp +++ b/components/shellsettingsplugin/mobileshellsettings.cpp @@ -91,7 +91,8 @@ void MobileShellSettings::setNavigationPanelEnabled(bool navigationPanelEnabled) group.writeEntry("navigationPanelEnabled", navigationPanelEnabled, KConfigGroup::Notify); m_config->sync(); - updateNavigationBarsInPlasma(navigationPanelEnabled); + // TODO: Gesture only mode setting is disabled until we get the kwin effect gesture working: https://invent.kde.org/plasma/plasma-mobile/-/issues/300 + // updateNavigationBarsInPlasma(navigationPanelEnabled); } bool MobileShellSettings::alwaysShowKeyboardToggleOnNavigationPanel() const diff --git a/kcms/mobileshell/ui/main.qml b/kcms/mobileshell/ui/main.qml index a24844a3..8e70b7cc 100644 --- a/kcms/mobileshell/ui/main.qml +++ b/kcms/mobileshell/ui/main.qml @@ -54,19 +54,20 @@ KCM.SimpleKCM { } FormCard.FormCard { - FormCard.FormSwitchDelegate { - id: gestureDelegate - text: i18n("Gesture-only Mode") - description: i18n("Whether to hide the navigation panel.") - checked: !ShellSettings.Settings.navigationPanelEnabled - onCheckedChanged: { - if (checked != !ShellSettings.Settings.navigationPanelEnabled) { - ShellSettings.Settings.navigationPanelEnabled = !checked; - } - } - } + // TODO: Gesture only mode setting is disabled until we get the kwin effect gesture working: https://invent.kde.org/plasma/plasma-mobile/-/issues/300 + // FormCard.FormSwitchDelegate { + // id: gestureDelegate + // text: i18n("Gesture-only Mode") + // description: i18n("Whether to hide the navigation panel.") + // checked: !ShellSettings.Settings.navigationPanelEnabled + // onCheckedChanged: { + // if (checked != !ShellSettings.Settings.navigationPanelEnabled) { + // ShellSettings.Settings.navigationPanelEnabled = !checked; + // } + // } + // } - FormCard.FormDelegateSeparator { visible: keyboardToggleDelegate.visible; above: gestureDelegate; below: keyboardToggleDelegate } + // FormCard.FormDelegateSeparator { visible: keyboardToggleDelegate.visible; above: gestureDelegate; below: keyboardToggleDelegate } FormCard.FormSwitchDelegate { id: keyboardToggleDelegate