WEFT_OS/.agents/commands/implement.md
Marco Allegretti dcc09f319d
docs: add engineering contract, contributor toolkit and templates
Add AGENTS.md as the single engineering contract: sources of truth,
evidence and proof requirements, ownership, working modes, the reviewed
change loop, maintenance isolation, decision authority, dependency and
fork rules, the 0.0.x to 0.1.0 release progression, and branch and
publication rules.

Add .agents/ with scope, implement, verify, maintenance and release
procedures; reviewer, architecture debt scout, simplicity and refactoring
roles; skills for the compositor, Servo rendering, runtime capabilities,
appd sessions, packages and data, Linux deployment, integration
verification and documentation; and verify.py, which runs the existing
check profiles with --locked from any directory, stops on the first
failure and supports --dry-run.

check_toolkit.py validates local links and heading anchors, metadata,
catalog coverage and issue forms. A new contributor-toolkit CI job runs
both. The structure follows the Resina Design System toolkit at
1e768064f57a1e403ab271822383e732795905a6, adapted to WEFT.

Validation, against the committed lockfiles:
- verify.py toolkit: checker passes, 28 runner/checker tests pass
- verify.py portable, demos, packages: pass
- verify.py linux, runtime, servo-embed: fail on existing defects
  (clippy collapsible_if in the winit backend, three clippy lints in
  weft-runtime with wasmtime-runtime, and an E0308 in the selected Servo
  revision's servo-layout); the runner reports the failing status

Add CONTRIBUTING.md, issue forms for defects and changes, maintenance
problems and decisions of direction, and a pull request template asking
for ownership, proof and the validation actually performed. README.md
links the contribution guide.
2026-10-09 08:34:48 +00:00

3.4 KiB

name description
implement Carry accepted scope through proof, implementation, validation and diff review to one atomic result.

Implement accepted scope

Input: an issue or an explicitly accepted task with an acceptance criterion. Read AGENTS.md and the matching skills. This procedure applies the reviewed change loop to contribution work and to each step of primary development. It adds no approval layer: in primary development, continue to the next accepted step after each accepted result.

  1. Inspect and confirm scope. Verify the problem against current source and evidence. If the acceptance criterion or proof is missing, use scope. An issue is not a decision; if one is required and unresolved, prepare it and work on something independent.
  2. Prepare the branch. Inspect git status, the current branch, worktrees and remotes. Fetch main and branch from it, or from the unmerged branch the work depends on, with a descriptive branch name. Preserve unrelated changes; never commit contribution work directly to main.
  3. Review the plan. Name the owner, the boundary touched, compatibility promises affected and the proof. Check uncertain APIs in the dependency source selected by the lockfile. Fix it here if the design crosses ownership.
  4. Establish proof. Reproduce a defect first. For new behavior, add the fixture or contract case that fails without the change. Identify which evidence needs a real environment (compositor, renderer, VM) and whether it is available.
  5. Implement the smallest complete change. Keep manifests, WIT, protocol, IPC types, documentation and callers coherent. No synthetic success paths.
  6. Validate with verify: the smallest sufficient profiles plus any boundary-specific evidence. Fix failures within scope. Explain every changed expectation; never re-bless output to make it pass.
  7. Review the actual diff with the reviewer, from a reviewer who did not write it when available, otherwise as a fresh separate pass whose limitation you state. Review git diff <base> <head> for commits, or both staged and unstaged diffs before committing.
  8. Correct, revalidate and re-review until no blocking finding remains. Recheck after material corrections, rebases and conflict resolutions.
  9. Commit atomically. Inspect git status and the complete diff; exclude generated, transient and local-environment files (for example lockfile changes caused by local [patch] overrides). Write the message for maintainers.
  10. Publish within authority. If pushing or opening a pull request is authorized and available, fill the pull request template and inspect automated review integrations first. Otherwise return the local result and the prepared description.
  11. Reassess the goal from the new repository state and continue with the next dependent step.

Report what changed, what proves it, the checks actually run with results, and material limitations. A separately actionable problem found on the way goes through the maintenance threshold instead of the pull request body. Completing a change grants no merge or release authority.