From f803c55a7353631f86edf8677825e56ba3b830bf Mon Sep 17 00:00:00 2001 From: Devin Lin Date: Tue, 16 Sep 2025 09:07:32 -0400 Subject: [PATCH] volumeosd: Ensure visibility of children is set This ensures that all elements in the volume OSD get the window visibility and can turn off any listeners. This avoids excessive bindings being triggered when the osd is closed and audio is played. --- .../mobileshell/qml/popups/volumeosd/VolumeChangedPopup.qml | 4 ++++ components/mobileshell/qml/popups/volumeosd/VolumeOSD.qml | 3 +++ 2 files changed, 7 insertions(+) diff --git a/components/mobileshell/qml/popups/volumeosd/VolumeChangedPopup.qml b/components/mobileshell/qml/popups/volumeosd/VolumeChangedPopup.qml index 26503c3a..8285856e 100644 --- a/components/mobileshell/qml/popups/volumeosd/VolumeChangedPopup.qml +++ b/components/mobileshell/qml/popups/volumeosd/VolumeChangedPopup.qml @@ -83,6 +83,10 @@ Window { ColumnLayout { id: cards + + // Ensure children get visibility state of window so that they don't update while closed + visible: window.visible + width: parent.width anchors.left: parent.left anchors.right: parent.right diff --git a/components/mobileshell/qml/popups/volumeosd/VolumeOSD.qml b/components/mobileshell/qml/popups/volumeosd/VolumeOSD.qml index 70039807..c7b119c8 100644 --- a/components/mobileshell/qml/popups/volumeosd/VolumeOSD.qml +++ b/components/mobileshell/qml/popups/volumeosd/VolumeOSD.qml @@ -77,6 +77,9 @@ Window { contentHeight: cards.implicitHeight boundsBehavior: Flickable.DragAndOvershootBounds + // Ensure children get visibility state of window so that they don't update while closed + visible: window.visible + pressDelay: 50 property real offset: -Kirigami.Units.gridUnit