From e18d5f73ede4953ad7925d646bd7227bb1aad4ce Mon Sep 17 00:00:00 2001 From: Devin Lin Date: Mon, 27 Jun 2022 17:29:34 -0400 Subject: [PATCH] osd/volume: Don't use padding in SwipeListItem to fix warnings --- components/mobileshell/qml/osd/volume/AudioApplet.qml | 9 +++++++++ components/mobileshell/qml/osd/volume/ListItemBase.qml | 5 ----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/components/mobileshell/qml/osd/volume/AudioApplet.qml b/components/mobileshell/qml/osd/volume/AudioApplet.qml index e2edfc04..c21edc83 100644 --- a/components/mobileshell/qml/osd/volume/AudioApplet.qml +++ b/components/mobileshell/qml/osd/volume/AudioApplet.qml @@ -72,6 +72,7 @@ ColumnLayout { level: 2 text: i18n("Outputs") Layout.fillWidth: true + Layout.topMargin: PlasmaCore.Units.smallSpacing Layout.leftMargin: PlasmaCore.Units.smallSpacing } @@ -82,6 +83,7 @@ ColumnLayout { model: paSinkFilterModel delegate: DeviceListItem { Layout.fillWidth: true + Layout.margins: PlasmaCore.Units.smallSpacing type: "sink" onlyone: sinkView.count === 1 } @@ -100,6 +102,7 @@ ColumnLayout { level: 2 text: i18n("Inputs") Layout.fillWidth: true + Layout.topMargin: PlasmaCore.Units.smallSpacing Layout.leftMargin: PlasmaCore.Units.smallSpacing } @@ -110,6 +113,7 @@ ColumnLayout { model: paSourceFilterModel delegate: DeviceListItem { Layout.fillWidth: true + Layout.margins: PlasmaCore.Units.smallSpacing type: "source" onlyone: sinkView.count === 1 } @@ -129,6 +133,7 @@ ColumnLayout { level: 2 text: i18n("Playback Streams") Layout.fillWidth: true + Layout.topMargin: PlasmaCore.Units.smallSpacing Layout.leftMargin: PlasmaCore.Units.smallSpacing } @@ -142,6 +147,7 @@ ColumnLayout { } delegate: StreamListItem { Layout.fillWidth: true + Layout.margins: PlasmaCore.Units.smallSpacing width: sourceOutputView.width type: "sink-input" devicesModel: sourceView.model @@ -159,6 +165,7 @@ ColumnLayout { delegate: StreamListItem { Layout.fillWidth: true + Layout.margins: PlasmaCore.Units.smallSpacing width: sourceOutputView.width type: "sink-input" devicesModel: sourceView.model @@ -179,6 +186,7 @@ ColumnLayout { level: 2 text: i18n("Recording Streams") Layout.fillWidth: true + Layout.topMargin: PlasmaCore.Units.smallSpacing Layout.leftMargin: PlasmaCore.Units.smallSpacing } @@ -192,6 +200,7 @@ ColumnLayout { } delegate: StreamListItem { Layout.fillWidth: true + Layout.margins: PlasmaCore.Units.smallSpacing width: sourceOutputView.width type: "source-output" devicesModel: sourceView.model diff --git a/components/mobileshell/qml/osd/volume/ListItemBase.qml b/components/mobileshell/qml/osd/volume/ListItemBase.qml index d39ce38b..b429749e 100644 --- a/components/mobileshell/qml/osd/volume/ListItemBase.qml +++ b/components/mobileshell/qml/osd/volume/ListItemBase.qml @@ -31,11 +31,6 @@ Kirigami.SwipeListItem { property alias iconUsesPlasmaTheme: clientIcon.usesPlasmaTheme property string type // sink, source, source-output - topPadding: PlasmaCore.Units.smallSpacing - bottomPadding: PlasmaCore.Units.smallSpacing - leftPadding: PlasmaCore.Units.smallSpacing - rightPadding: PlasmaCore.Units.smallSpacing - alwaysVisibleActions: true backgroundColor: "transparent" // we use panel background, no need for the same colour to be on top