From d9b2e987dc15a0a5fdbc6f2ddae55ff6615f8853 Mon Sep 17 00:00:00 2001 From: Marco Allegretti Date: Mon, 4 May 2026 20:25:28 +0200 Subject: [PATCH] Drop snap-assist hover stub from decoration The decoration QML sandbox has no DBus or kglobalaccel access, so the Qt.callDBus call from the maximize-button hover Timer was a silent no-op. Remove the dead Timer, hover state and grid-dot overlay; the shift-tiling script now polls the cursor over the title-bar button strip and triggers SHIFT Snap Assist itself. Also refresh the SPDX header on both decoration files. --- kwin/decorations/CMakeLists.txt | 5 ++--- .../org.shift.decoration/contents/ui/main.qml | 9 +++++++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/kwin/decorations/CMakeLists.txt b/kwin/decorations/CMakeLists.txt index 164cbc27..3d24a8c3 100644 --- a/kwin/decorations/CMakeLists.txt +++ b/kwin/decorations/CMakeLists.txt @@ -1,6 +1,5 @@ -# SPDX-FileCopyrightText: 2025 SHIFT Contributors -# SPDX-License-Identifier: GPL-2.0-or-later - +# SPDX-FileCopyrightText: 2026 Marco Allegretti < +# SPDX-License-Identifier: EUPL-1.2 install( DIRECTORY org.shift.decoration DESTINATION ${KDE_INSTALL_DATADIR}/kwin/decorations diff --git a/kwin/decorations/org.shift.decoration/contents/ui/main.qml b/kwin/decorations/org.shift.decoration/contents/ui/main.qml index c26a6c6e..bf9561d8 100644 --- a/kwin/decorations/org.shift.decoration/contents/ui/main.qml +++ b/kwin/decorations/org.shift.decoration/contents/ui/main.qml @@ -1,5 +1,5 @@ -// SPDX-FileCopyrightText: 2025 SHIFT Contributors -// SPDX-License-Identifier: GPL-2.0-or-later +// SPDX-FileCopyrightText: 2026 Marco Allegretti +// SPDX-License-Identifier: EUPL 1.2 import QtQuick import org.kde.kwin.decoration @@ -181,6 +181,11 @@ Decoration { } } + // Snap-assist hover trigger lives in the shift-tiling KWin script: + // the decoration QML sandbox has no DBus / kglobalaccel access, so + // the script polls the cursor over the active window's titlebar + // and invokes the SHIFT Snap Assist shortcut after a short hover. + Rectangle { visible: !isSpacer anchors.fill: parent