marcoallegretti/shift-shell
1
0
Fork 0
mirror of https://invent.kde.org/marcoa/shift-shell.git synced 2026-08-01 17:24:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

taskpanel: Delay setting panel position on screen change, so shell doesn't crash

Browse source 
Setting it immediately seems to trigger an underlying bug that causes the shell to crash, see https://invent.kde.org/plasma/plasma-mobile/-/issues/321

I've cherry-picked this for Plasma 6 so we don't have this issue on stable, but I'm not sure if we should merge this into master or keep trying to identify the root cause.
This commit is contained in:
Devin Lin 2024-03-03 21:39:21 -05:00
parent 7cb6ebaae1
commit b553850e0a
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
containments/taskpanel/package/contents/ui/main.qml
View file

@ -46,15 +46,24 @@ ContainmentItem {
readonly property int intendedWindowLocation: inLandscape ? PlasmaCore.Types.RightEdge : PlasmaCore.Types.BottomEdge readonly property int intendedWindowLocation: inLandscape ? PlasmaCore.Types.RightEdge : PlasmaCore.Types.BottomEdge
onIntendedWindowLengthChanged: maximizeTimer.restart() // ensure it always takes up the full length of the screen onIntendedWindowLengthChanged: maximizeTimer.restart() // ensure it always takes up the full length of the screen
onIntendedWindowLocationChanged: { onIntendedWindowLocationChanged: setPanelLocationTimer.restart()
root.panel.location = intendedWindowLocation;
}
onIntendedWindowOffsetChanged: { onIntendedWindowOffsetChanged: {
if (root.panel) { if (root.panel) {
root.panel.offset = intendedWindowOffset; root.panel.offset = intendedWindowOffset;
} }
} }
// HACK: the entire shell seems to crash sometimes if this is applied immediately after a display change (ex. screen rotation)
// see https://invent.kde.org/plasma/plasma-mobile/-/issues/321
Timer {
id: setPanelLocationTimer
running: false
interval: 100
onTriggered: {
root.panel.location = intendedWindowLocation;
}
}
// use a timer so we don't have to maximize for every single pixel // use a timer so we don't have to maximize for every single pixel
// - improves performance if the shell is run in a window, and can be resized // - improves performance if the shell is run in a window, and can be resized
Timer { Timer {