From afe97d41f823ff1f581498eebdddca010811419a Mon Sep 17 00:00:00 2001 From: Marco Allegretti Date: Sat, 23 May 2026 15:33:48 +0200 Subject: [PATCH] Show X for Overview desktop deletion KWin Overview 6.6 asks for the raw delete icon name on its virtual desktop delete button. Provide delete and delete-symbolic in the Shift icon theme, and point nearby KDE delete aliases at the existing close glyph so the button renders as an X instead of a fallback icon. Guard the aliases in the icon theme coverage check. --- .../actions/symbolic/delete-symbolic.svg | 1 + icons/org.shift.icons/actions/symbolic/delete.svg | 1 + .../symbolic/edit-delete-remove-symbolic.svg | 2 +- .../actions/symbolic/edit-delete-remove.svg | 2 +- .../actions/symbolic/edit-delete-symbolic.svg | 1 + .../actions/symbolic/edit-delete.svg | 2 +- tests/check-shift-icon-theme.sh | 14 ++++++++++++++ 7 files changed, 20 insertions(+), 3 deletions(-) create mode 120000 icons/org.shift.icons/actions/symbolic/delete-symbolic.svg create mode 120000 icons/org.shift.icons/actions/symbolic/delete.svg create mode 120000 icons/org.shift.icons/actions/symbolic/edit-delete-symbolic.svg diff --git a/icons/org.shift.icons/actions/symbolic/delete-symbolic.svg b/icons/org.shift.icons/actions/symbolic/delete-symbolic.svg new file mode 120000 index 00000000..a3ce6e3f --- /dev/null +++ b/icons/org.shift.icons/actions/symbolic/delete-symbolic.svg @@ -0,0 +1 @@ +window-close-symbolic.svg \ No newline at end of file diff --git a/icons/org.shift.icons/actions/symbolic/delete.svg b/icons/org.shift.icons/actions/symbolic/delete.svg new file mode 120000 index 00000000..b9439718 --- /dev/null +++ b/icons/org.shift.icons/actions/symbolic/delete.svg @@ -0,0 +1 @@ +window-close.svg \ No newline at end of file diff --git a/icons/org.shift.icons/actions/symbolic/edit-delete-remove-symbolic.svg b/icons/org.shift.icons/actions/symbolic/edit-delete-remove-symbolic.svg index 0e78c06d..a3ce6e3f 120000 --- a/icons/org.shift.icons/actions/symbolic/edit-delete-remove-symbolic.svg +++ b/icons/org.shift.icons/actions/symbolic/edit-delete-remove-symbolic.svg @@ -1 +1 @@ -trash-empty.svg \ No newline at end of file +window-close-symbolic.svg \ No newline at end of file diff --git a/icons/org.shift.icons/actions/symbolic/edit-delete-remove.svg b/icons/org.shift.icons/actions/symbolic/edit-delete-remove.svg index 0e78c06d..b9439718 120000 --- a/icons/org.shift.icons/actions/symbolic/edit-delete-remove.svg +++ b/icons/org.shift.icons/actions/symbolic/edit-delete-remove.svg @@ -1 +1 @@ -trash-empty.svg \ No newline at end of file +window-close.svg \ No newline at end of file diff --git a/icons/org.shift.icons/actions/symbolic/edit-delete-symbolic.svg b/icons/org.shift.icons/actions/symbolic/edit-delete-symbolic.svg new file mode 120000 index 00000000..a3ce6e3f --- /dev/null +++ b/icons/org.shift.icons/actions/symbolic/edit-delete-symbolic.svg @@ -0,0 +1 @@ +window-close-symbolic.svg \ No newline at end of file diff --git a/icons/org.shift.icons/actions/symbolic/edit-delete.svg b/icons/org.shift.icons/actions/symbolic/edit-delete.svg index 0e78c06d..b9439718 120000 --- a/icons/org.shift.icons/actions/symbolic/edit-delete.svg +++ b/icons/org.shift.icons/actions/symbolic/edit-delete.svg @@ -1 +1 @@ -trash-empty.svg \ No newline at end of file +window-close.svg \ No newline at end of file diff --git a/tests/check-shift-icon-theme.sh b/tests/check-shift-icon-theme.sh index 6e63af07..83fe5742 100644 --- a/tests/check-shift-icon-theme.sh +++ b/tests/check-shift-icon-theme.sh @@ -181,6 +181,20 @@ require_line "$theme_dir/index.theme" '^\[apps/scalable\]$' \ "org.shift.icons index.theme is missing [apps/scalable]" require_line "$theme_dir/index.theme" '^\[preferences/scalable\]$' \ "org.shift.icons index.theme is missing [preferences/scalable]" + +[[ "$(readlink "$theme_dir/actions/symbolic/delete.svg")" == "window-close.svg" ]] \ + || fail "delete must resolve to the X close glyph for KWin Overview's virtual desktop delete button" +[[ "$(readlink "$theme_dir/actions/symbolic/delete-symbolic.svg")" == "window-close-symbolic.svg" ]] \ + || fail "delete-symbolic must resolve to the symbolic X close glyph for KWin Overview's virtual desktop delete button" +[[ "$(readlink "$theme_dir/actions/symbolic/edit-delete.svg")" == "window-close.svg" ]] \ + || fail "edit-delete must resolve to the X close glyph for KWin Overview's virtual desktop delete button" +[[ "$(readlink "$theme_dir/actions/symbolic/edit-delete-symbolic.svg")" == "window-close-symbolic.svg" ]] \ + || fail "edit-delete-symbolic must resolve to the symbolic X close glyph for KWin Overview's virtual desktop delete button" +[[ "$(readlink "$theme_dir/actions/symbolic/edit-delete-remove.svg")" == "window-close.svg" ]] \ + || fail "edit-delete-remove must resolve to the X close glyph for KWin Overview's virtual desktop delete button" +[[ "$(readlink "$theme_dir/actions/symbolic/edit-delete-remove-symbolic.svg")" == "window-close-symbolic.svg" ]] \ + || fail "edit-delete-remove-symbolic must resolve to the symbolic X close glyph for KWin Overview's virtual desktop delete button" + check_systemsettings_category_icons check_systemsettings_module_icons