marcoallegretti/shift-shell
1
0
Fork 0
mirror of https://invent.kde.org/marcoa/shift-shell.git synced 2026-04-26 06:13:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add null guards in QuickSettingsDelegate and convergentwindows

Browse source 
Check restrictedPermissions before opening the detail popup in
convergence mode. Guard against null output in the KWin script
window-setup handler to prevent TypeError when a window has no
assigned output yet.
This commit is contained in:
Marco Allegretti 2026-04-18 20:24:28 +02:00
parent 8fecdf1d2d
commit aa4103f72a
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
components/mobileshell/qml/actiondrawer/private/QuickSettingsDelegate.qml
View file

@ -101,7 +101,7 @@ MobileShell.BaseItem {
function delegatePressAndHold() {
// In convergence mode, show inline detail popup if available.
if (ShellSettings.Settings.convergenceModeEnabled && root.settingsCommand) {
if (ShellSettings.Settings.convergenceModeEnabled && root.settingsCommand && !root.restrictedPermissions) {
let pluginId = __appletForCommand[root.settingsCommand];
if (pluginId) {
root.detailRequested(pluginId);

1
kwin/scripts/convergentwindows/contents/ui/main.qml
View file

@ -31,6 +31,7 @@ Loader {
const output = window.output
const desktop = window.desktops[0]
if (!output) return
if (!desktop) return
const maxRect = KWinComponents.Workspace.clientArea(