marcoallegretti/shift-shell
1
0
Fork 0
mirror of https://invent.kde.org/marcoa/shift-shell.git synced 2026-04-26 14:23:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

kwin/convergentwindows: Don't set maximize property for fullscreen windows

Browse source 
Followup to https://invent.kde.org/teams/plasma-mobile/issues/-/issues/256

Otherwise the positioning affects shell windows too
This commit is contained in:
Devin Lin 2024-03-04 14:30:37 -05:00
parent b553850e0a
commit a748ecda5b
1 changed files with 14 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
kwin/scripts/convergentwindows/contents/ui/main.qml
View file

@ -13,20 +13,24 @@ Loader {
if (ShellSettings.Settings.convergenceModeEnabled) { if (ShellSettings.Settings.convergenceModeEnabled) {
window.noBorder = false; window.noBorder = false;
} else { } else {
const output = window.output; if (!window.fullScreen) {
const desktop = window.desktops[0]; // assume it's the first desktop that the window is on const output = window.output;
const maximizeRect = KWinComponents.Workspace.clientArea(KWinComponents.Workspace.MaximizeArea, output, desktop); const desktop = window.desktops[0]; // assume it's the first desktop that the window is on
const maximizeRect = KWinComponents.Workspace.clientArea(KWinComponents.Workspace.MaximizeArea, output, desktop);
// set the window to the maximized size and position instantly, avoiding race condition // set the window to the maximized size and position instantly, avoiding race condition
// between maximizing and window decorations being turned off (changing window height) // between maximizing and window decorations being turned off (changing window height)
// see: https://invent.kde.org/teams/plasma-mobile/issues/-/issues/256 // see: https://invent.kde.org/teams/plasma-mobile/issues/-/issues/256
window.frameGeometry = maximizeRect; window.frameGeometry = maximizeRect;
}
// turn off window decorations // turn off window decorations
window.noBorder = true; window.noBorder = true;
// run maximize after to ensure the state is maximized if (!window.fullScreen) {
window.setMaximize(true, true); // run maximize after to ensure the state is maximized
window.setMaximize(true, true);
}
} }
} }