quicksettings: request -symbolic icons for masked tiles

Kirigami.Icon { isMask: true } flattens an SVG to its alpha, so when a quick-setting tile resolves to a colored preferences/scalable glyph the whole rounded background collapses into a solid square. Append -symbolic to the five icon names that collided with colored tiles and add symlink aliases where no real symbolic variant exists yet. Guard the regression with a check in tests/check-shift-icon-theme.sh.

icons/org.shift.icons/actions/symbolic/dialog-information-symbolic.svg

@@ -0,0 +1 @@
+dialog-information.svg

icons/org.shift.icons/actions/symbolic/preferences-desktop-display-randr-symbolic.svg

@@ -0,0 +1 @@
+preferences-desktop-display-randr.svg

icons/org.shift.icons/actions/symbolic/redshift-status-on-symbolic.svg

@@ -0,0 +1 @@
+redshift-status-on.svg

quicksettings/docked/contents/ui/main.qml

@@ -9,7 +9,7 @@ import org.kde.plasma.private.mobileshell.quicksettingsplugin as QS
 
 QS.QuickSetting {
     text: i18n("Docked Mode")
-    icon: "preferences-desktop-display-randr"
+    icon: "preferences-desktop-display-randr-symbolic"
     enabled: ShellSettings.Settings.convergenceModeEnabled
 
     function toggle() {

quicksettings/gaminghint/contents/ui/main.qml

@@ -8,7 +8,7 @@ import org.kde.plasma.private.mobileshell.quicksettingsplugin as QS
 
 QS.QuickSetting {
     text: i18n("Launch Hint")
-    icon: "dialog-information"
+    icon: "dialog-information-symbolic"
     status: ShellSettings.Settings.gamingDismissHintEnabled ? i18n("On") : i18n("Off")
     enabled: true
     available: ShellSettings.Settings.gamingModeEnabled

quicksettings/hotspot/contents/ui/main.qml

@@ -10,7 +10,7 @@ QS.QuickSetting {
     id: root
 
     text: i18n("Hotspot")
-    icon: "network-wireless-hotspot"
+    icon: "network-wireless-hotspot-symbolic"
 
     enabled: MobileShell.NetworkInfo.wirelessStatus.hotspotSSID.length !== 0
     status: enabled ? MobileShell.NetworkInfo.wirelessStatus.hotspotSSID : ""

quicksettings/keyboardtoggle/contents/ui/main.qml

@@ -10,7 +10,7 @@ import org.kde.plasma.workspace.keyboardlayout 1.0 as Keyboards
 
 QS.QuickSetting {
     text: i18n("Virtual Keyboard")
-    icon: "input-keyboard-virtual"
+    icon: "input-keyboard-virtual-symbolic"
     status: enabled ? i18n("On") :
                       (Keyboards.KWinVirtualKeyboard.available ? i18n("Off") : i18n("Tap to open settings"))
     enabled: Keyboards.KWinVirtualKeyboard.enabled && Keyboards.KWinVirtualKeyboard.available

quicksettings/nightcolor/package/contents/ui/main.qml

@@ -11,7 +11,7 @@ import org.kde.plasma.private.mobileshell.quicksettingsplugin as QS
 
 QS.QuickSetting {
     text: i18n("Night Color")
-    icon: "redshift-status-on"
+    icon: "redshift-status-on-symbolic"
     enabled: NightColor.NightColorUtil.enabled
     status: ""
     settingsCommand: "plasma-open-settings kcm_nightcolor"

tests/check-shift-icon-theme.sh

@@ -255,4 +255,29 @@ if [[ -s "$missing_icons" ]]; then
     printf 'Missing required Shift icons:\n' >&2
     sed 's/^/  - /' "$missing_icons" >&2
     exit 1
+fi
+
+# Quick-setting tiles render with Kirigami.Icon { isMask: true }; if their icon
+# name resolves to a colored preferences/scalable tile it collapses to a solid
+# rounded square. Require an explicit -symbolic suffix for any quick-setting
+# icon name that also exists as a colored tile.
+masked_collisions="$(mktemp)"
+trap 'rm -f "$required_icons" "$missing_icons" "$broken_icons" "$plasma_files" "$masked_collisions"' EXIT
+
+while IFS= read -r -d '' qml; do
+    perl -ne 'if (/^\s*icon:\s*"([^"]+)"\s*$/) { print "$1\n"; }' "$qml"
+done < <(find quicksettings -name 'main.qml' -print0) \
+    | sort -u \
+    | while IFS= read -r icon_name; do
+        case "$icon_name" in
+            *-symbolic) continue ;;
+        esac
+        [[ -e "$theme_dir/preferences/scalable/$icon_name.svg" ]] || continue
+        printf '%s\n' "$icon_name"
+    done > "$masked_collisions"
+
+if [[ -s "$masked_collisions" ]]; then
+    printf 'Quick-setting icon names must use a -symbolic suffix when a colored preferences/scalable tile exists, otherwise the masked tile renders as a solid square:\n' >&2
+    sed 's/^/  - /' "$masked_collisions" >&2
+    exit 1
 fi