From 7d23e94f81fbda24e0a22b30d90f8d88a58dd0bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luis=20B=C3=BCchi?= Date: Fri, 5 Apr 2024 18:39:30 +0200 Subject: [PATCH] remove touch border reservations that broke initial gesture usage setBorder already reserves/unreserves touch borders appropriately, doing that manually beforehand only led to the gesture not working (double reservation?) until using the action drawer once --- .../mobiletaskswitchereffect.cpp | 16 +--------------- .../mobiletaskswitchereffect.h | 2 +- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/kwin/mobiletaskswitcher/mobiletaskswitchereffect.cpp b/kwin/mobiletaskswitcher/mobiletaskswitchereffect.cpp index 965f195b..fd08f5ec 100644 --- a/kwin/mobiletaskswitcher/mobiletaskswitchereffect.cpp +++ b/kwin/mobiletaskswitcher/mobiletaskswitchereffect.cpp @@ -63,21 +63,7 @@ MobileTaskSwitcherEffect::~MobileTaskSwitcherEffect() void MobileTaskSwitcherEffect::reconfigure(ReconfigureFlags) { setAnimationDuration(animationTime(300ms)); - - for (const ElectricBorder &border : std::as_const(m_borderActivate)) { - effects->unreserveElectricBorder(border, this); - } - - m_borderActivate.clear(); - - const QList activateBorders = {ElectricBorder::ElectricBottom}; - for (const int &border : activateBorders) { - ElectricBorder electricBorder = ElectricBorder(border); - m_borderActivate.append(electricBorder); - effects->reserveElectricBorder(electricBorder, this); - } - - m_border->setBorders(activateBorders); + m_border->setBorders(m_borderActivate); } int MobileTaskSwitcherEffect::requestedEffectChainPosition() const diff --git a/kwin/mobiletaskswitcher/mobiletaskswitchereffect.h b/kwin/mobiletaskswitcher/mobiletaskswitchereffect.h index b6b8fc3f..f50a2a18 100644 --- a/kwin/mobiletaskswitcher/mobiletaskswitchereffect.h +++ b/kwin/mobiletaskswitcher/mobiletaskswitchereffect.h @@ -61,7 +61,7 @@ Q_SIGNALS: private: EffectTogglableState *const m_taskSwitcherState; EffectTogglableTouchBorder *const m_border; - QList m_borderActivate; + QList m_borderActivate = {ElectricBorder::ElectricBottom}; QAction *m_realtimeToggleAction = nullptr; QAction *m_toggleAction = nullptr;