marcoallegretti/shift-shell
1
0
Fork 0
mirror of https://invent.kde.org/marcoa/shift-shell.git synced 2026-04-29 15:03:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

taskswitcher: Remove all interaction restrictions while the task switcher is opening

Browse source 
This allows users to properly interact (open apps, dismiss) while the task switcher is in its opening animation.

This fixes tapping on an app while the task switcher is opening dismissing the task switcher entirely (due to race condition)
This commit is contained in:
Devin Lin 2024-03-04 13:12:34 -05:00
parent b5e58a8db1
commit 7cb6ebaae1
3 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
kwin/mobiletaskswitcher/qml/Task.qml
View file

@ -57,7 +57,6 @@ Item {
id: control id: control
width: parent.width width: parent.width
height: parent.height height: parent.height
enabled: !taskSwitcher.taskSwitcherState.currentlyBeingOpened
// set cursor shape here, since taphandler seems to not be able to do it // set cursor shape here, since taphandler seems to not be able to do it
cursorShape: Qt.PointingHandCursor cursorShape: Qt.PointingHandCursor
@ -70,7 +69,7 @@ Item {
} }
onClicked: { onClicked: {
if (!taskSwitcher.taskSwitcherState.currentlyBeingOpened && !passedDragThreshold) { if (!passedDragThreshold) {
delegate.activateApp(); delegate.activateApp();
} }
} }

4
kwin/mobiletaskswitcher/qml/TaskList.qml
View file

@ -76,9 +76,7 @@ MouseArea {
onClicked: { onClicked: {
// if tapped on the background, then hide // if tapped on the background, then hide
if (!taskSwitcherState.currentlyBeingOpened) { taskSwitcher.hide();
taskSwitcher.hide();
}
} }
onPressedChanged: { onPressedChanged: {

4
kwin/mobiletaskswitcher/qml/TaskSwitcherState.qml
View file

@ -136,6 +136,10 @@ QtObject {
} }
function openApp(index, window) { function openApp(index, window) {
// cancel any opening animations ongoing
currentlyBeingOpened = false;
cancelAnimations();
animateGoToTaskIndex(index, Kirigami.Units.shortDuration); animateGoToTaskIndex(index, Kirigami.Units.shortDuration);
openAppAnim.restart(); openAppAnim.restart();
KWinComponents.Workspace.activeWindow = window KWinComponents.Workspace.activeWindow = window