From 41de61ef4c5cbfca7a1d831abc31a9f2818fc260 Mon Sep 17 00:00:00 2001 From: Devin Lin Date: Thu, 11 Jul 2024 23:48:32 -0400 Subject: [PATCH] quicksettingsplugin: Fix improper model implementation --- components/quicksettingsplugin/quicksettingsmodel.cpp | 2 +- components/quicksettingsplugin/savedquicksettingsmodel.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/components/quicksettingsplugin/quicksettingsmodel.cpp b/components/quicksettingsplugin/quicksettingsmodel.cpp index c228f5ef..2f5576ce 100644 --- a/components/quicksettingsplugin/quicksettingsmodel.cpp +++ b/components/quicksettingsplugin/quicksettingsmodel.cpp @@ -205,7 +205,7 @@ void QuickSettingsModel::insertQuickSettingToModel(KPluginMetaData metaData, Qui } if (emitInsertSignal) { - beginInsertRows({}, insertIndex, 0); + beginInsertRows({}, insertIndex, insertIndex); } m_quickSettings.insert(insertIndex, quickSetting); diff --git a/components/quicksettingsplugin/savedquicksettingsmodel.cpp b/components/quicksettingsplugin/savedquicksettingsmodel.cpp index 217db876..163a45dd 100644 --- a/components/quicksettingsplugin/savedquicksettingsmodel.cpp +++ b/components/quicksettingsplugin/savedquicksettingsmodel.cpp @@ -50,9 +50,9 @@ void SavedQuickSettingsModel::moveRow(int oldIndex, int newIndex) void SavedQuickSettingsModel::insertRow(KPluginMetaData metaData, int index) { - Q_EMIT beginInsertRows(QModelIndex(), index, index); + beginInsertRows(QModelIndex(), index, index); m_data.insert(index, metaData); - Q_EMIT endInsertRows(); + endInsertRows(); Q_EMIT dataUpdated(m_data); }