marcoallegretti/shift-shell
1
0
Fork 0
mirror of https://invent.kde.org/marcoa/shift-shell.git synced 2026-06-11 00:47:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Guard convergentwindows against invalid windows

Browse source 
Return early in run(window) when the window object is null, deleted, or non-normal before accessing resourceClass. This prevents runtime errors during window lifecycle races.
This commit is contained in:
Marco Allegretti 2026-05-04 08:43:15 +02:00
parent e72165ec98
commit 378e4830ac
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
kwin/scripts/convergentwindows/contents/ui/main.qml
View file

@ -53,13 +53,13 @@ Loader {
} }
function run(window) { function run(window) {
// HACK: don't maximize xwaylandvideobridge if (!window || window.deleted || !window.normalWindow) {
// see: https://invent.kde.org/plasma/plasma-mobile/-/issues/324
if (window.resourceClass === 'xwaylandvideobridge') {
return; return;
} }
if (!window.normalWindow) { // HACK: don't maximize xwaylandvideobridge
// see: https://invent.kde.org/plasma/plasma-mobile/-/issues/324
if (window.resourceClass === 'xwaylandvideobridge') {
return; return;
} }