marcoallegretti/shift-shell
1
0
Fork 0
mirror of https://invent.kde.org/marcoa/shift-shell.git synced 2026-04-26 14:23:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

MobileShell: Fix CMake Set Source Files Properties

Browse source 
I noticed that properties in `MobileShell.Constants` were not being applied correctly, causing values to show up as undefined. After investigating, it seem to be a recent change attempted to condense multiple `set_source_files_properties` calls in `MobileShell/CMakeList.txt` into one call. However, the issue seems to be that the properties were still being set inline with each file, instead of listing all files together followed by a single `PROPERTIES` keyword. This merge requests resolves this issue by moving the property specification to the end of the file list, ensuring that all files receive the intended properties.
This commit is contained in:
Micah Stanley 2025-04-26 06:58:40 +00:00 committed by Devin Lin
parent 66b53d0bc0
commit 121fd39f12
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
components/mobileshell/CMakeLists.txt
View file

@ -18,14 +18,16 @@ target_sources(mobileshellplugin PRIVATE ${mobileshellplugin_SRCS})
# Singleton declarations
set_source_files_properties(
qml/components/AppLaunch.qml PROPERTIES QT_QML_SINGLETON_TYPE TRUE
qml/components/Constants.qml PROPERTIES QT_QML_SINGLETON_TYPE TRUE
qml/dataproviders/AudioInfo.qml PROPERTIES QT_QML_SINGLETON_TYPE TRUE
qml/dataproviders/BatteryInfo.qml PROPERTIES QT_QML_SINGLETON_TYPE TRUE
qml/dataproviders/BluetoothInfo.qml PROPERTIES QT_QML_SINGLETON_TYPE TRUE
qml/dataproviders/NetworkInfo.qml PROPERTIES QT_QML_SINGLETON_TYPE TRUE
qml/dataproviders/SignalStrengthInfo.qml PROPERTIES QT_QML_SINGLETON_TYPE TRUE
qml/popups/PopupProviderLoader.qml PROPERTIES QT_QML_SINGLETON_TYPE TRUE
qml/components/AppLaunch.qml
qml/components/Constants.qml
qml/dataproviders/AudioInfo.qml
qml/dataproviders/BatteryInfo.qml
qml/dataproviders/BluetoothInfo.qml
qml/dataproviders/NetworkInfo.qml
qml/dataproviders/SignalStrengthInfo.qml
qml/popups/PopupProviderLoader.qml
PROPERTIES
QT_QML_SINGLETON_TYPE TRUE
)
# Include qml and js files within ./qml/