marcoallegretti/karapace
1
0
Fork 0
mirror of https://github.com/marcoallegretti/karapace.git synced 2026-03-26 21:43:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(store): avoid panic in metadata checksum

Browse source
This commit is contained in:
Marco Allegretti 2026-02-25 12:48:11 +01:00
parent c576321479
commit c1e2650617
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
crates/karapace-store/src/metadata.rs
View file

@ -48,13 +48,12 @@ pub struct EnvMetadata {
impl EnvMetadata { impl EnvMetadata {
/// Compute the checksum over the metadata content (excluding the checksum field itself). /// Compute the checksum over the metadata content (excluding the checksum field itself).
fn compute_checksum(&self) -> String { fn compute_checksum(&self) -> Result<String, StoreError> {
let mut copy = self.clone(); let mut copy = self.clone();
copy.checksum = None; copy.checksum = None;
// Serialize without the checksum field (skip_serializing_if = None) // Serialize without the checksum field (skip_serializing_if = None)
let json = let json = serde_json::to_string_pretty(&copy)?;
serde_json::to_string_pretty(&copy).expect("infallible: EnvMetadata always serializes"); Ok(blake3::hash(json.as_bytes()).to_hex().to_string())
blake3::hash(json.as_bytes()).to_hex().to_string()
} }
} }
@ -89,7 +88,7 @@ impl MetadataStore {
// Compute and embed checksum before writing // Compute and embed checksum before writing
let mut meta_with_checksum = meta.clone(); let mut meta_with_checksum = meta.clone();
meta_with_checksum.checksum = Some(meta_with_checksum.compute_checksum()); meta_with_checksum.checksum = Some(meta_with_checksum.compute_checksum()?);
let content = serde_json::to_string_pretty(&meta_with_checksum)?; let content = serde_json::to_string_pretty(&meta_with_checksum)?;
let dir = self.layout.metadata_dir(); let dir = self.layout.metadata_dir();
@ -112,7 +111,7 @@ impl MetadataStore {
// Verify checksum if present (backward-compatible: legacy files have None) // Verify checksum if present (backward-compatible: legacy files have None)
if let Some(ref expected) = meta.checksum { if let Some(ref expected) = meta.checksum {
let actual = meta.compute_checksum(); let actual = meta.compute_checksum()?;
if actual != *expected { if actual != *expected {
return Err(StoreError::IntegrityFailure { return Err(StoreError::IntegrityFailure {
hash: env_id.to_owned(), hash: env_id.to_owned(),