marcoallegretti/WEFT_OS
marcoallegretti/WEFT_OS
1
0
Fork 0
mirror of https://github.com/marcoallegretti/WEFT_OS.git synced 2026-03-26 17:03:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(appd): combine set_state and broadcast into one lock acquisition on READY

Browse source 
The two consecutive registry lock acquisitions after READY left a window
where session state was Running but the AppReady broadcast had not yet
been sent. A concurrent reader winning the lock in that window would
observe Running without a corresponding event. Combining into one
acquisition closes the window.
This commit is contained in:
Marco Allegretti 2026-03-13 14:07:06 +01:00
parent e02ce5722d
commit cd13f4cd3a
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
crates/weft-appd/src/runtime.rs
View file

@ -315,14 +315,14 @@ pub(crate) async fn supervise(
let app_shell = match ready_result { let app_shell = match ready_result {
Some(Ok(Ok(remaining_stdout))) => { Some(Ok(Ok(remaining_stdout))) => {
registry {
.lock() let mut reg = registry.lock().await;
.await reg.set_state(session_id, AppStateKind::Running);
.set_state(session_id, AppStateKind::Running); let _ = reg.broadcast().send(Response::AppReady {
let _ = registry.lock().await.broadcast().send(Response::AppReady { session_id,
session_id, app_id: app_id.to_owned(),
app_id: app_id.to_owned(), });
}); }
tracing::info!(session_id, %app_id, "app ready"); tracing::info!(session_id, %app_id, "app ready");
tokio::spawn(drain_stdout(remaining_stdout, session_id)); tokio::spawn(drain_stdout(remaining_stdout, session_id));
spawn_app_shell(session_id, app_id).await spawn_app_shell(session_id, app_id).await