marcoallegretti/WEFT_OS
marcoallegretti/WEFT_OS
1
0
Fork 0
mirror of https://github.com/marcoallegretti/WEFT_OS.git synced 2026-03-27 01:13:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(servo-shell): guard create_app_webview against duplicate session_id

Browse source 
A broadcast LaunchAck can arrive in addition to any direct response,
causing create_app_webview to be called twice for the same session.
Without the guard the second call silently overwrites the existing
WebView entry without destroying it. Early-return if the session is
already tracked.
This commit is contained in:
Marco Allegretti 2026-03-11 18:31:35 +01:00
parent 9448cc5140
commit c9e1eb5075
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
crates/weft-servo-shell/src/embedder.rs
View file

@ -133,6 +133,9 @@ impl App {
} }
fn create_app_webview(&mut self, session_id: u64, app_id: &str) { fn create_app_webview(&mut self, session_id: u64, app_id: &str) {
if self.app_webviews.contains_key(&session_id) {
return;
}
let (Some(servo), Some(rc)) = (&self.servo, &self.rendering_context) else { let (Some(servo), Some(rc)) = (&self.servo, &self.rendering_context) else {
return; return;
}; };