From 73dc2cbaa5e8d82fb5697aca4be9aead2cf6d95a Mon Sep 17 00:00:00 2001 From: Marco Allegretti Date: Fri, 9 Oct 2026 20:21:26 +0000 Subject: [PATCH] fix(shells): report the Super keys to pages as Meta winit names the Super keys NamedKey::Super, which the key conversion did not map, so pages saw an Unidentified key. The DOM names these keys Meta. --- crates/weft-app-shell/src/keyutils.rs | 3 ++- crates/weft-servo-shell/src/keyutils.rs | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/crates/weft-app-shell/src/keyutils.rs b/crates/weft-app-shell/src/keyutils.rs index 1665cb5..ba4bdf5 100644 --- a/crates/weft-app-shell/src/keyutils.rs +++ b/crates/weft-app-shell/src/keyutils.rs @@ -57,7 +57,8 @@ fn named_key(n: NamedKey) -> servo::NamedKey { NamedKey::Control => S::Control, NamedKey::Fn => S::Fn, NamedKey::FnLock => S::FnLock, - NamedKey::Meta => S::Meta, + // winit names the Super keys Super; the DOM names them Meta. + NamedKey::Meta | NamedKey::Super => S::Meta, NamedKey::NumLock => S::NumLock, NamedKey::ScrollLock => S::ScrollLock, NamedKey::Shift => S::Shift, diff --git a/crates/weft-servo-shell/src/keyutils.rs b/crates/weft-servo-shell/src/keyutils.rs index 1665cb5..ba4bdf5 100644 --- a/crates/weft-servo-shell/src/keyutils.rs +++ b/crates/weft-servo-shell/src/keyutils.rs @@ -57,7 +57,8 @@ fn named_key(n: NamedKey) -> servo::NamedKey { NamedKey::Control => S::Control, NamedKey::Fn => S::Fn, NamedKey::FnLock => S::FnLock, - NamedKey::Meta => S::Meta, + // winit names the Super keys Super; the DOM names them Meta. + NamedKey::Meta | NamedKey::Super => S::Meta, NamedKey::NumLock => S::NumLock, NamedKey::ScrollLock => S::ScrollLock, NamedKey::Shift => S::Shift,