mirror of
https://github.com/marcoallegretti/WEFT_OS.git
synced 2026-11-22 08:13:59 +00:00
docs: stop runner toolchain installs and widen maintenance form
The verification runner inherited rustup's default of installing a missing pinned toolchain or component on demand, contradicting its documented guarantee. Run every profile with RUSTUP_AUTO_INSTALL=0 so a missing toolchain fails the check, and document how to install it. The maintenance form and CONTRIBUTING described only duplication and fallback problems, while the architecture debt scout also reports ownership, untrusted-authority and unenforced-grant problems through that form. Widen both descriptions to match. Correct the README CI trigger to pushes to main and pull requests. This branch builds on docs/add-stability-blueprint, which adds the BLUEPRINT.md the contract and toolkit checks link to; merge that first. Validation, against the committed lockfiles: - verify.py toolkit: checker passes, 28 tests pass - verify.py portable packages: pass
This commit is contained in:
parent
39869a2a38
commit
2658141350
6 changed files with 13 additions and 6 deletions
|
|
@ -75,7 +75,9 @@ profiles. It needs Python 3.10 or newer. It works from any directory, runs fixed
|
|||
argument arrays from the repository root without a shell, stops at the first
|
||||
failure and returns its status. It never formats files, installs packages or
|
||||
toolchain targets, regenerates expectations, signs packages, commits or
|
||||
publishes.
|
||||
publishes. It sets `RUSTUP_AUTO_INSTALL=0`, so a missing pinned toolchain or
|
||||
component fails the check instead of being downloaded; install it with
|
||||
`rustup show` or `rustup component add`.
|
||||
|
||||
```sh
|
||||
python .agents/scripts/verify.py --help
|
||||
|
|
|
|||
|
|
@ -175,6 +175,7 @@ class Runner(unittest.TestCase):
|
|||
self.assertEqual(run.call_count, 2)
|
||||
for call in run.call_args_list:
|
||||
self.assertEqual(call.kwargs["cwd"], ROOT)
|
||||
self.assertEqual(call.kwargs["env"]["RUSTUP_AUTO_INSTALL"], "0")
|
||||
self.assertIsInstance(call.args[0], list)
|
||||
|
||||
def test_failure_stops_remaining_checks_and_keeps_status(self):
|
||||
|
|
|
|||
|
|
@ -5,6 +5,7 @@ The runner stops at the first failing command and returns its exit status.
|
|||
"""
|
||||
|
||||
import argparse
|
||||
import os
|
||||
import subprocess
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
|
@ -12,6 +13,9 @@ from pathlib import Path
|
|||
|
||||
ROOT = Path(__file__).resolve().parents[2]
|
||||
|
||||
# Stop rustup from installing the pinned toolchain or its components on demand.
|
||||
ENVIRONMENT = {**os.environ, "RUSTUP_AUTO_INSTALL": "0"}
|
||||
|
||||
LINUX_CRATES = ["weft-compositor", "weft-servo-shell", "weft-app-shell"]
|
||||
DEMOS = ["examples/org.weft.demo.counter", "examples/org.weft.demo.notes"]
|
||||
DEMO_KEY = "examples/keys/weft-sign.pub"
|
||||
|
|
@ -110,7 +114,7 @@ def main(argv=None):
|
|||
if args.dry_run:
|
||||
continue
|
||||
try:
|
||||
result = subprocess.run(command, cwd=ROOT, check=False)
|
||||
result = subprocess.run(command, cwd=ROOT, env=ENVIRONMENT, check=False)
|
||||
except OSError as error:
|
||||
print(f"[{profile}] cannot run {command[0]}: {error}", file=sys.stderr)
|
||||
return 1
|
||||
|
|
|
|||
4
.github/ISSUE_TEMPLATE/maintenance.yml
vendored
4
.github/ISSUE_TEMPLATE/maintenance.yml
vendored
|
|
@ -1,5 +1,5 @@
|
|||
name: Maintenance
|
||||
description: Report one present duplication, structural or misleading-fallback problem that is independent of active development.
|
||||
description: Report one present ownership, boundary, enforcement or structural problem that is independent of active development.
|
||||
body:
|
||||
- type: markdown
|
||||
attributes:
|
||||
|
|
@ -11,7 +11,7 @@ body:
|
|||
id: observed
|
||||
attributes:
|
||||
label: Observed
|
||||
description: One concrete duplicated decision, unnecessary state, misleading fallback, coupling or obsolete path, and who or what it affects today.
|
||||
description: One concrete problem (responsibility held by the wrong owner, authority taken from untrusted input, a grant declared but not enforced, a duplicated decision, unnecessary state, a misleading fallback, coupling or an obsolete path) and who or what it affects today.
|
||||
validations:
|
||||
required: true
|
||||
- type: textarea
|
||||
|
|
|
|||
|
|
@ -18,7 +18,7 @@ pull requests first, then open a
|
|||
|
||||
- **Defect or change** for a concrete problem or ordinary work within accepted
|
||||
architecture.
|
||||
- **Maintenance** for one present duplication, structural or misleading-fallback
|
||||
- **Maintenance** for one present ownership, boundary, enforcement or structural
|
||||
problem outside active development.
|
||||
- **Decision** for a material change of product direction, public compatibility,
|
||||
trust boundaries, support scope or data policy. Opening it does not approve the
|
||||
|
|
|
|||
|
|
@ -75,7 +75,7 @@ See `docs/building.md` for full instructions including Wasm component builds, Ni
|
|||
|
||||
## CI
|
||||
|
||||
Four jobs on every push and pull request:
|
||||
Four jobs on every push to `main` and on pull requests:
|
||||
|
||||
- `cross-platform` — fmt, clippy, tests on Ubuntu and Windows
|
||||
- `linux-only` — clippy and tests for compositor and shell crates
|
||||
|
|
|
|||
Loading…
Reference in a new issue