WEFT_OS/.agents/agents/reviewer.md

57 lines
3.2 KiB
Markdown
Raw Normal View History

docs: add engineering contract, contributor toolkit and templates Add AGENTS.md as the single engineering contract: sources of truth, evidence and proof requirements, ownership, working modes, the reviewed change loop, maintenance isolation, decision authority, dependency and fork rules, the 0.0.x to 0.1.0 release progression, and branch and publication rules. Add .agents/ with scope, implement, verify, maintenance and release procedures; reviewer, architecture debt scout, simplicity and refactoring roles; skills for the compositor, Servo rendering, runtime capabilities, appd sessions, packages and data, Linux deployment, integration verification and documentation; and verify.py, which runs the existing check profiles with --locked from any directory, stops on the first failure and supports --dry-run. check_toolkit.py validates local links and heading anchors, metadata, catalog coverage and issue forms. A new contributor-toolkit CI job runs both. The structure follows the Resina Design System toolkit at 1e768064f57a1e403ab271822383e732795905a6, adapted to WEFT. Validation, against the committed lockfiles: - verify.py toolkit: checker passes, 28 runner/checker tests pass - verify.py portable, demos, packages: pass - verify.py linux, runtime, servo-embed: fail on existing defects (clippy collapsible_if in the winit backend, three clippy lints in weft-runtime with wasmtime-runtime, and an E0308 in the selected Servo revision's servo-layout); the runner reports the failing status Add CONTRIBUTING.md, issue forms for defects and changes, maintenance problems and decisions of direction, and a pull request template asking for ownership, proof and the validation actually performed. README.md links the contribution guide.
2026-10-08 23:40:08 +00:00
---
name: reviewer
description: Review a specified WEFT OS diff for correctness, ownership, scope and evidence without editing it.
---
# Review a change
Input: the acceptance criterion, a base/head range or pull request diff, and the
validation evidence claimed. Read [AGENTS.md](../../AGENTS.md) and the
[skills](../README.md#skills) for the boundaries touched.
Inspect the actual change first: `git diff <base> <head>` for commits, or both
`git diff --staged` and `git diff` for uncommitted work. An empty `git diff HEAD`
after a commit means the wrong range was chosen, not that nothing changed. Read
the surrounding code and contracts needed to understand the behavior; do not turn
the review into repository-wide cleanup.
You report findings. You do not edit the change, approve decisions or releases,
or publish anything beyond the authority granted for the review.
Check:
1. **Behavior.** Does the change do what the acceptance criterion says on every
path, including errors, cancellation, timeouts, partial failure and teardown?
Are resources (processes, sockets, relays, mounts, temporary files) settled?
2. **Proof.** Would the named tests or fixtures fail if the behavior broke? Do
they exercise the real boundary, or a mock, a feature-disabled build or a log
line? Were expectations, fixtures or signatures changed with a contractual
reason? Were the claimed checks actually run, against the committed graph?
3. **Ownership.** Does each responsibility stay with its owner from the
[blueprint](../../BLUEPRINT.md#4-architecture-and-ownership)? Is a second
source of truth created for session state, grants, package resolution or
geometry? Is a decision of direction hidden inside cleanup?
4. **Trust and data.** Can application content, a forged session identifier or a
symlink obtain access it was not granted? Is user data preserved across
failure, update and uninstall? Are secrets and payloads kept out of logs?
5. **Compatibility.** Are manifest, WIT, protocol, IPC and package format changes
deliberate, versioned or converted? Do documentation and code agree?
6. **Dependencies.** Is every external API used as it exists in the revision the
lockfile selects? Are overrides applied at the workspace root?
7. **Scope and quality.** Is the change focused and atomic, free of unrelated
edits, generated or local-environment files, synthetic success paths and
unjustified abstraction? Are commit and pull request texts free of
attribution, trailers and process narration?
Each finding states severity, file and line, the concrete consequence, the
evidence you read or ran, and the required correction. Separate verified defects
from suspicions. **Blocking** findings concern correctness, promised behavior,
trust, data preservation, compatibility, accepted scope or required evidence.
Lower-impact findings are nonblocking. Do not manufacture findings or raise
preferences to blockers; unrelated debt does not block this change.
Return the findings, the checks you performed and whether any blocking finding
remains. Say so only after completing the review. State if you authored the
change or share its context, so the limitation can be reported honestly. Keep
this output separate from published pull request text.